CFM-31_Enrollment_Flows_enable_people_picker_for_self_service #337
+73
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
force-pushed
the
CFM-31_Enrollment_Flows_enable_people_picker_for_self_service
branch
from
0b5171b
to
ac177db
Compare
|
Previous Pull Request. It contains the review comments. |
Ioannis
deleted the
CFM-31_Enrollment_Flows_enable_people_picker_for_self_service
branch
benno
reviewed
Sep 18, 2025
Comment on lines
+439
to
+463
| $petitionId = (int)$request->getQuery('petition_id'); | ||
| // We need to check if this is part of an Enrollment Flow | ||
| $Petitions = $this->fetchTable('Petitions'); | ||
|
|
||
| // Pull the Petition to find its CO | ||
| $petition = $Petitions->get( | ||
| $petitionId, | ||
| contain: ['EnrollmentFlows' => ['EnrollmentFlowSteps']] | ||
| ); | ||
|
|
||
| // We need to check the Petitioner Authorization. | ||
| $hasAuthorizedUser = $petition->enrollment_flow->authz_type == EnrollmentAuthzEnum::AuthUser | ||
| ? !empty($auth['external']['user']) : true; | ||
|
|
||
| foreach ($petition->enrollment_flow->enrollment_flow_steps as $step) { | ||
| if ($step->plugin == 'CoreEnroller.AttributeCollectors') { | ||
| $AttributeCollectors = $this->fetchTable('CoreEnroller.AttributeCollectors'); | ||
| $attributeCollectorsRecord = $AttributeCollectors->find() | ||
| ->where(['enrollment_flow_step_id' => $step->id]) | ||
| ->contain(['EnrollmentAttributes']) | ||
| ->first(); | ||
|
|
||
| $mode = $hasAuthorizedUser && $attributeCollectorsRecord->enable_person_find ? 'yes' : 'no'; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a lot of special logic for an API controller. While we can probably leave the outermost test (if(People && pick && petition_id)) in place until we have more use cases to refactor, the actual logic of whether or not the PeoplePicker is enabled should go in PetitionsTable. Or really in EnrollmentFlowsTable, but since we have a Petition ID as context here, and there is a similar function PetitionsTable::isApproverForFlow() already, PetitionsTable::isPersonFindEnabled() probably makes more sense.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable people picker functionality as an AttributeCollector configuration